Memoise a couple of selectors (#1137)

Ensembl · May 22, 2024 · ec36402 · ec36402
1 parent 18aa31f
commit ec36402
Showing 1 changed file with 20 additions and 15 deletions.
diff --git a/src/content/app/entity-viewer/state/gene-view/transcripts/geneViewTranscriptsSelectors.ts b/src/content/app/entity-viewer/state/gene-view/transcripts/geneViewTranscriptsSelectors.ts
@@ -14,6 +14,8 @@
  * limitations under the License.
  */
 
+import { createSelector } from '@reduxjs/toolkit';
+
 import {
   getEntityViewerActiveGenomeId,
   getEntityViewerActiveEntityId
@@ -26,18 +28,19 @@ import {
   SortingRule
 } from './geneViewTranscriptsSlice';
 
-const getSliceForGene = (
-  state: RootState
-): TranscriptsStatePerGene | undefined => {
-  const activeGenomeId = getEntityViewerActiveGenomeId(state);
-  const activeEntityId = getEntityViewerActiveEntityId(state);
-  if (!activeGenomeId || !activeEntityId) {
-    return;
+const getSliceForGene = createSelector(
+  [
+    getEntityViewerActiveGenomeId,
+    getEntityViewerActiveEntityId,
+    (state: RootState) => state
+  ],
+  (genomeId, entityId, state): TranscriptsStatePerGene | undefined => {
+    if (!genomeId || !entityId) {
+      return;
+    }
+    return state.entityViewer.geneView.transcripts[genomeId]?.[entityId];
   }
-  return state.entityViewer.geneView.transcripts[activeGenomeId]?.[
-    activeEntityId
-  ];
-};
+);
 
 export const getExpandedTranscriptIds = (state: RootState): string[] => {
   const transcriptsSlice = getSliceForGene(state);
@@ -58,10 +61,12 @@ export const getExpandedTranscriptMoreInfoIds = (
   return transcriptsSlice?.expandedMoreInfoIds ?? [];
 };
 
-export const getFilters = (state: RootState): Filters => {
-  const transcriptsSlice = getSliceForGene(state);
-  return transcriptsSlice?.filters ?? {};
-};
+export const getFilters = createSelector(
+  [getSliceForGene],
+  (transcriptsSlice): Filters => {
+    return transcriptsSlice?.filters ?? {};
+  }
+);
 
 export const getSortingRule = (state: RootState): SortingRule => {
   const transcriptsSlice = getSliceForGene(state);