Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chunk section editing #2621

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

octylFractal
Copy link
Member

@octylFractal octylFractal commented Sep 7, 2024

Currently Fabric-only.

Fixes #2516

TODO:

  • Config opt
  • Clean up code
  • NeoForge
  • Paper (augh reflection)

@octylFractal octylFractal added the type:performance Performance-related issue label Sep 7, 2024
@octylFractal octylFractal added this to the 7.3.7 milestone Sep 7, 2024
@octylFractal octylFractal self-assigned this Sep 7, 2024
@octylFractal octylFractal changed the base branch from version/7.3.x to master September 12, 2024 02:19
@octylFractal octylFractal force-pushed the ot/featurefix/oooooo-you-like-editing-chunks-ur-a-chunk-section-editor branch from 3f1652b to deb26cb Compare September 12, 2024 02:19
@octylFractal octylFractal marked this pull request as ready for review September 12, 2024 02:19
@octylFractal octylFractal requested a review from a team as a code owner September 12, 2024 02:19
@octylFractal octylFractal modified the milestones: 7.3.7, 7.4.0 Sep 12, 2024
Needs to be updated to the new integrations at some point
@octylFractal
Copy link
Member Author

@avaruus1 if you're interested in keeping the Sponge part up-to-date with everything, there are changes here that need to be made. As we don't want to maintain it, I just removed the broken code. This won't land for at least a couple months so there's plenty of time to adjust.

@avaruus1
Copy link
Contributor

avaruus1 commented Oct 3, 2024

@avaruus1 if you're interested in keeping the Sponge part up-to-date with everything, there are changes here that need to be made. As we don't want to maintain it, I just removed the broken code. This won't land for at least a couple months so there's plenty of time to adjust.

I think the side effect calculation is fine to remove as is. The block change flags are set already here. Is there some other scenarios where this is possibly used?

@octylFractal
Copy link
Member Author

No, it's only useful if the platform calls out to it. If you don't want to port the chunk section stuff then there should be nothing to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:performance Performance-related issue
Development

Successfully merging this pull request may close these issues.

2 participants