-
-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chunk section editing #2621
base: master
Are you sure you want to change the base?
Chunk section editing #2621
Conversation
And also drop all the old stuff that doesn't build any more and I'm _not_ going back and fixing it
3f1652b
to
deb26cb
Compare
Needs to be updated to the new integrations at some point
@avaruus1 if you're interested in keeping the Sponge part up-to-date with everything, there are changes here that need to be made. As we don't want to maintain it, I just removed the broken code. This won't land for at least a couple months so there's plenty of time to adjust. |
I think the side effect calculation is fine to remove as is. The block change flags are set already here. Is there some other scenarios where this is possibly used? |
No, it's only useful if the platform calls out to it. If you don't want to port the chunk section stuff then there should be nothing to do. |
Currently Fabric-only.
Fixes #2516
TODO: