Rename saturn.svg to saturn-symbolic.svg
#70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes white-on-white issue when using Light Style extension
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the "Light style" extension is enabled, the saturn icon stays white even though the background is also white. This PR simply changes the name to add
-symbolic.svgsuch that the saturn icon becomes dark on a white background.Let me know if the saturn file is used anywhere else and should be updated there as well. I saw "saturn" mentioned in
notifications.js, but I was not sure if it needed to be updated tosaturn.svg(and I don't seem to be getting notifications, with this branch or the main one so I could not double check this). Let me know if it should be updated.Also, this is a very small PR, so of course feel free to just close it if you prefer to fix/test this on your end and push it afterwards.
Thanks!