fix: DeepMutable tuples (#2879)

Effect-TS · May 30, 2024 · cc8ac50 · cc8ac50
1 parent e83e4f5
commit cc8ac50
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/.changeset/thin-bears-switch.md b/.changeset/thin-bears-switch.md
@@ -0,0 +1,5 @@
+---
+"effect": patch
+---
+
+Support tuples in Types.DeepMutable
diff --git a/packages/effect/dtslint/Types.ts b/packages/effect/dtslint/Types.ts
@@ -96,6 +96,9 @@ hole<Types.DeepMutable<ReadonlyMap<TaggedValues<string>, ReadonlySet<TaggedValue
 // $ExpectType { _tag: string; value: { _tag: string; value: { _tag: string; value: boolean[]; }[]; }[]; }[]
 hole<Types.DeepMutable<ReadonlyArray<TaggedValues<TaggedValues<TaggedValues<boolean>>>>>>()
 
+// $ExpectType [string, number, boolean]
+hole<Types.DeepMutable<readonly [string, number, boolean]>>()
+
 // -------------------------------------------------------------------------------------
 // MatchRecord
 // -------------------------------------------------------------------------------------

diff --git a/packages/effect/src/Types.ts b/packages/effect/src/Types.ts
@@ -187,7 +187,7 @@ export type Mutable<T> = {
  */
 export type DeepMutable<T> = T extends ReadonlyMap<infer K, infer V> ? Map<DeepMutable<K>, DeepMutable<V>>
  : T extends ReadonlySet<infer V> ? Set<DeepMutable<V>>
- : T extends ReadonlyArray<infer V> ? Array<DeepMutable<V>>
+ : T extends ReadonlyArray<any> ? { -readonly [K in keyof T]: DeepMutable<T[K]> }
  : [keyof T] extends [never] ? T
  : { -readonly [K in keyof T]: DeepMutable<T[K]> }