Micro optimization to avoid inline creation & spreading of objects / …

…arrays (#1847)
Effect-TS · Jan 1, 2024 · bcf0900 · bcf0900
1 parent 693b8f3
commit bcf0900
Show file tree

Hide file tree

Showing 6 changed files with 18 additions and 9 deletions.
diff --git a/.changeset/neat-geese-brush.md b/.changeset/neat-geese-brush.md
@@ -0,0 +1,7 @@
+---
+"@effect/opentelemetry": patch
+"@effect/platform": patch
+"effect": patch
+---
+
+Avoid inline creation & spreading of objects and arrays
diff --git a/packages/effect/src/internal/core-effect.ts b/packages/effect/src/internal/core-effect.ts
@@ -2033,11 +2033,13 @@ export const makeSpan = (
  : Context.getOption(context, internalTracer.spanTag)
 
  const links = linksFromEnv._tag === "Some" ?
- [
- ...Chunk.toReadonlyArray(linksFromEnv.value),
- ...(options?.links ?? [])
- ] :
- options?.links ?? []
+ options?.links !== undefined ?
+ [
+ ...Chunk.toReadonlyArray(linksFromEnv.value),
+ ...options?.links ?? []
+ ] :
+ Chunk.toReadonlyArray(linksFromEnv.value) :
+ options?.links ?? ReadonlyArray.empty()
 
  const span = tracer.span(
  name,

diff --git a/packages/opentelemetry/src/NodeSdk.ts b/packages/opentelemetry/src/NodeSdk.ts
@@ -44,7 +44,7 @@ export const layerTracerProvider = (
  Effect.acquireRelease(
  Effect.sync(() => {
  const provider = new NodeTracerProvider({
- ...(config ?? {}),
+ ...(config ?? undefined),
  resource
  })
  provider.addSpanProcessor(processor)

diff --git a/packages/opentelemetry/src/Resource.ts b/packages/opentelemetry/src/Resource.ts
@@ -30,7 +30,7 @@ export const layer = (config: {
  readonly attributes?: Resources.ResourceAttributes
 }) => {
  const attributes = {
- ...(config.attributes ?? {}),
+ ...(config.attributes ?? undefined),
  [SemanticResourceAttributes.SERVICE_NAME]: config.serviceName,
  [SemanticResourceAttributes.TELEMETRY_SDK_NAME]: "@effect/opentelemetry",
  [SemanticResourceAttributes.TELEMETRY_SDK_LANGUAGE]: typeof (globalThis as any).document === "undefined"

diff --git a/packages/opentelemetry/src/WebSdk.ts b/packages/opentelemetry/src/WebSdk.ts
@@ -44,7 +44,7 @@ export const layerTracerProvider = (
  Effect.acquireRelease(
  Effect.sync(() => {
  const provider = new WebTracerProvider({
- ...(config ?? {}),
+ ...(config ?? undefined),
  resource
  })
  provider.addSpanProcessor(processor)

diff --git a/packages/platform/src/internal/http/clientRequest.ts b/packages/platform/src/internal/http/clientRequest.ts
@@ -55,7 +55,7 @@ export const make: {
  modify(empty, {
  method,
  url,
- ...(options ?? {})
+ ...(options ?? undefined)
  })
 
 /** @internal */