fix fork semantics

Effect-TS · Jun 1, 2024 · b5473bf · b5473bf
1 parent 548f88f
commit b5473bf
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/packages/effect/src/Micro.ts b/packages/effect/src/Micro.ts
@@ -2543,12 +2543,12 @@ export const fork = <A, E, R>(self: Micro<A, E, R>): Micro<Handle<A, E>, never,
  map[currentAbortSignal.key] = handle._controller.signal
  return map
  })
- Promise.resolve().then(() => {
+ yieldAdd(() => {
  self[runSymbol](nextEnv, (result) => {
  handle.emit(result)
  })
- onResult(Either.right(handle))
  })
+ onResult(Either.right(handle))
  })
 
 /**
@@ -2564,12 +2564,12 @@ export const forkDaemon = <A, E, R>(self: Micro<A, E, R>): Micro<Handle<A, E>, n
  map[currentAbortSignal.key] = controller.signal
  return map
  })
- Promise.resolve().then(() => {
+ yieldAdd(() => {
  self[runSymbol](nextEnv, (result) => {
  handle.emit(result)
  })
- onResult(Either.right(handle))
  })
+ onResult(Either.right(handle))
  })
 
 // ----------------------------------------------------------------------------

diff --git a/packages/effect/test/Micro.test.ts b/packages/effect/test/Micro.test.ts
@@ -265,6 +265,7 @@ describe.sequential("Micro", () => {
  release = true
  })
  ).pipe(Micro.scoped, Micro.fork)
+ yield* Micro.yieldNow
  handle.unsafeAbort()
  yield* handle.await
  assert.strictEqual(release, true)
@@ -468,8 +469,7 @@ describe.sequential("Micro", () => {
  Micro.gen(function*() {
  const error = yield* new TestError().pipe(Micro.flip)
  assert.deepStrictEqual(error, new TestError())
- assert.include(error.stack, "Micro.test.ts:469")
- console.log(error.stack)
+ assert.include(error.stack, "Micro.test.ts:470")
  }))
 
  it.effect("is a valid Effect", () =>