Toast functionality and contact section UI done #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Viveksati5143
approved these changes
Jul 12, 2023
|
Please check it now. I did the needful, now it is okay to merge |
Viveksati5143
approved these changes
Jul 14, 2023
|
Can you please merge this PR. I am not getting option at my end to merge. |
Viveksati5143
approved these changes
Jul 14, 2023
|
@SahityaRoy & @Viveksati5143 can you please merge the PR Toast functionality and contact section UI done #456. It has been approved by the reviewer, i am not getting the merge option at my end. that's why can you do merge please. |
Viveksati5143
approved these changes
Aug 3, 2023
|
I have resolved the merge conflict please review and merge it under GSSOC'23. Have a look @Viveksati5143 @Athi223 @bLaCkwEw @ShahzaibJutt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Older version : Contact Section UI was not upto the mark and there was no toast functionality.
Closes #395
Description
New Version: I have modified the contact section and applied the colors which match with website UI. Further more I implemented toast functionality which will show error messages and success message accordingly. You can see the attached screenshots for reference. I have created a PR please have a look!
I am raising another issue for smtp js to send email to designated email of eduhub please assign that task to me. I will like to carry out it further and make it full fledged working contact section
Screenshots
Checklist