Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Use body for POST/PUT/PATCH and query for GET/DELETE requests #310

Merged
merged 3 commits into from
Aug 1, 2024

Conversation

nwithan8
Copy link
Member

Description

Fix underlying client logic to always use query parameters for GET/DELETE requests and body for POST/PUT/PATCH requests.

Testing

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@nwithan8 nwithan8 requested a review from a team July 29, 2024 17:36
@Justintime50
Copy link
Member

I think this diff is going to require a mass re-recording of cassettes

@nwithan8
Copy link
Member Author

I think this diff is going to require a mass re-recording of cassettes

Yes, it will. Our cassettes are stale anyway, so might as well re-record all of them.

@nwithan8 nwithan8 merged commit 195fa40 into master Aug 1, 2024
8 checks passed
@nwithan8 nwithan8 deleted the http_spec branch August 1, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants