Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds new recommend_ship_date and estimate_delivery_date functions #306

Merged
merged 7 commits into from
Jul 12, 2024

Conversation

jchen293
Copy link
Member

Description

Adds new shipment.recommend_ship_date, smartrate.recommend_ship_date, and smartrate.estimate_delivery_date functions

Testing

Add unit tests to make sure new functions work

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@jchen293 jchen293 requested a review from a team July 11, 2024 18:57
lib/easypost/models/smartrate.rb Outdated Show resolved Hide resolved
lib/easypost/services/smartrate.rb Outdated Show resolved Hide resolved
lib/easypost/services/smartrate.rb Outdated Show resolved Hide resolved
@jchen293 jchen293 merged commit 4caf5c7 into master Jul 12, 2024
8 checks passed
@jchen293 jchen293 deleted the smartrate_functions branch July 12, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants