Remove create_and_buy from batch service #289

jchen293 · 2023-12-01T18:54:29Z

Description

Removes the undocumented create_and_buy function from the Batch service. The proper usage is to create a batch first and buy it separately

Rubocop released a new version yesterday and caused a few linting errors, this PR also fixed it

Remove the test and cassette

Please select the option(s) that are relevant to this PR.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Improvement (fixing a typo, updating readme, renaming a variable name, etc)

remove create_and_buy from batch service

da2046d

jchen293 requested a review from a team December 1, 2023 18:54

jchen293 added 2 commits December 1, 2023 14:51

update example submodule

b871067

point to a rubocop version

16dea01

Justintime50 approved these changes Dec 1, 2023

View reviewed changes

fix lint

358aec9

nwithan8 self-requested a review December 1, 2023 20:09

nwithan8 approved these changes Dec 1, 2023

View reviewed changes

jchen293 merged commit ef38ca5 into master Dec 1, 2023
7 checks passed

jchen293 deleted the remove_create_and_buy branch December 1, 2023 20:09