Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GasChem.jl Update #108

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

GasChem.jl Update #108

wants to merge 4 commits into from

Conversation

jialinl6
Copy link
Collaborator

  • Update FastJX O₃ + hv → 2OH photolysis reaction rate calculation algorithm and SuperFast reaction system.
  • Not ready to be merged into the main GasChem.jl due to the coupling issue between the new SuperFast and other differential equation systems, such as emissions, which needs to be fixed.

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 93.84615% with 8 lines in your changes missing coverage. Please review.

Project coverage is 97.28%. Comparing base (a5dafb7) to head (4dcb780).
Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
ext/EarthSciDataExt.jl 12.50% 7 Missing ⚠️
src/SuperFast.jl 98.93% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #108      +/-   ##
==========================================
- Coverage   99.08%   97.28%   -1.80%     
==========================================
  Files           7        7              
  Lines         545      663     +118     
==========================================
+ Hits          540      645     +105     
- Misses          5       18      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant