-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug in path to CAM script cam.case_setup.py #4604
Fix bug in path to CAM script cam.case_setup.py #4604
Conversation
@lizziel Please sync with master, this will clear up the failed check. |
7cb54ca
to
fde0e2f
Compare
All set. I had to add CIME/non_py/cprnc during my rebase but it looks like the rebase worked out fine. |
@lizziel this branch is messed up with respect to master, there are a lot of changes I'm sure that you did not intend. Can you try again? |
@lizziel @jedwards4b This was my mistake, I asked to sync with master and missed it being based on |
Let me know if you want me to rebase on a different commit. |
@jedwards4b, do you have an idea of when you can apply this fix? I can rebase it onto whatever target branch you plan to merge it into. Without this fix GEOS-Chem will not work in CAM. |
I don't want to see a commit that changes 25 files - fix that and we can merge. |
fde0e2f
to
8258b5f
Compare
I assume you want this targeting master so I cherry-picked to that. It is now back to the simple directory path fix. |
Looks better, now we just need to get tests working, black wants the following change:
|
8258b5f
to
d9176d7
Compare
All set, but tests are still failing. |
You introduced an indentation error, 428 is indented too far. You should install pre-commit and use it, would save a lot of time. |
Just prior to the cime6.0.217 tag there was a change in the original code to call cam.case_setup.py during case setup. The change added a conditional for file path existence, but the file path added was incorrect. This causes the script to never be called and GEOS-Chem compsets will subsequently all fail. Signed-off-by: Lizzie Lundgren <[email protected]>
d9176d7
to
5dbce34
Compare
@jasonb5 containers are still failing. |
Sorry, I am not familiar with these tests. Could you interpret the error message for me?
|
@lizziel this is a problem we've been having recently with the cime testing, I don't think it's your PR. |
github container testing appears broken again. |
Thank you! |
Just prior to the
cime6.0.217
tag there was a change in the original code to callcam.case_setup.py
during case setup. The change added a conditional for file path existence, but the file path added was
incorrect. This causes the script to never be called and GEOS-Chem compsets will subsequently all fail.
Tagging @cacraigucar since this bug makes me wonder if GEOS-Chem tests are running, or if I am missing something else that changed that would make the existing code work.
Test suite: N/A
Test baseline: N/A
Test namelist changes: N/A
Test status: [bit for bit, roundoff, climate changing]
Fixes [CIME Github issue #] none
User interface changes?: N
Update gh-pages html (Y/N)?: N