Initialize machine to None #4596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows the logic in the _v2 version of this function. Resolves ESMCI#4588
jedwards4b
approved these changes
Mar 12, 2024
jasonb5
approved these changes
Mar 12, 2024
|
@jedwards4b @billsacks Tests are running now, I'll fix the cause of the issue in another PR. |
billsacks
added a commit
that referenced
this pull request
Mar 12, 2024
Fix undefined machine on cime6.0.217_httpsbranch branch Initialize machine to None to prevent not initializing it to anything. This is cherry-picked from #4596 Testing: Run CTSM python testing (which was failing before this change) ./scripts_regression_tests.py (currently running) Test status: bit-for-bit Fix for #4588 on the httpsbranch branch. This fixes issues in CTSM discussed here: ESCOMP/CTSM#2385 (comment) User interface changes?: None Update gh-pages html (Y/N)?: N
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows the logic in the _v2 version of this function, as well as the documentation in "_probe_machine_name_one_guess" ("Returns None if no match is found").
Test suite: None (just manually tested the issue documented in #4588 ).
Test baseline: none
Test namelist changes: none
Test status: bit for bit
Fixes #4588
User interface changes?: N
Update gh-pages html (Y/N)?: N