need to make sure the directory exists before linking to it #4582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jasonb5 What is the current status of testing and how do we move forward? |
fischer-ncar
approved these changes
Feb 21, 2024
|
@jedwards4b working on a fix #4584 |
|
@jedwards4b Merge master and the workflow related issues should be resolved. Keep in mind if you do need to make changes to the container in the future the PR needs to be made from a repo branch otherwise it will not be build and use the new container for testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ERI test was failing after running the first ref case, its because the second run directory wasn't created and thus it wasn't possible to create links within it, I added code to create this directory if it doesn't already exist.
Test suite:scripts_regression_tests
Test baseline:
Test namelist changes:
Test status: bit for bit
Fixes
User interface changes?:
Update gh-pages html (Y/N)?: