-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix and improve anomaly forcings for ISSP cases #2686
Draft
samsrabin
wants to merge
28
commits into
ESCOMP:master
Choose a base branch
from
samsrabin:ssp-anomaly-fixes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of having to specify anomaly_forcing = 'Anomaly.Forcing.Precip', 'Anomaly.Forcing.Temperature', etc.
Branch ssp-fix: Fix more typos of "anomaly."
Branch ssp-fix: Add Anomaly.Forcing.cmip6.ssp126.
ssp-fix branch: Add Anomaly.Forcing.cmip6.245, 370, 585.
Branch ssp-fix: Merge tag 'cdeps1.0.34' into ssp-fix
Branch ssp-fix: "anomaly_forcing now automatically set based on compset (ISSP*)." Also updates testmods accordingly.
Branch ssp-fix: Now actually sets anomaly_forcing based on compset.
samsrabin
force-pushed
the
ssp-anomaly-fixes
branch
from
September 5, 2024 15:43
0a71fe6
to
728257b
Compare
Branch ssp-fix: Only set anomaly_forcing for DATM SSP compsets.
Branch ssp-fix: Provide hint in error message if namelist variable invalid due to surrounding quote marks.
Branch ssp-fix: Make datm buildnml more robust.
To match what's run in aux_clm.
Branch ssp-fix: Bugfix to future-proofing of datm buildnml.
samsrabin
added
the
enhancement
new capability or improved behavior of existing capability
label
Sep 5, 2024
samsrabin
added
blocked: dependency
Wait to work on this until dependency is resolved
external
issue needs to be addressed elsewhere (submodule); issue here for the sake of project tracking
labels
Oct 8, 2024
Marking as blocked while I wait on the ESCOMP/CDEPS#292 PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
blocked: dependency
Wait to work on this until dependency is resolved
bug
something is working incorrectly
enhancement
new capability or improved behavior of existing capability
external
issue needs to be addressed elsewhere (submodule); issue here for the sake of project tracking
usability
Improve or clarify user-facing options
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixes a bug, and also makes it much simpler to run land-only SSP cases. Depends on ESCOMP/CDEPS#292.
Specific notes
Contributors other than yourself, if any: @ekluzek
CTSM Issues Fixed (include github issue #):
Are answers expected to change (and if so in what way)? Yes, for cases that were being bitten by #2301 before.
Any User Interface Changes (namelist or namelist defaults changes)? Yes; see ESCOMP/CDEPS#292.
Does this create a need to change or add documentation? Did you do so? Yes; yes.
Testing performed, if any:
datm_rcp45_anom_forc
test unaffected as of 4b96267.datm_ssp126_anom_forc
test unaffected as of c4ec313.Remaining work
ssp
test suite: Removedatm_ssp*_anom_forc
testmods, replacing tests using those withdefault
Running-with-anomaly-forcing.rst
ISSP126
test with 10x15ISSP245
test? Would presumably be quicker to get through queue.tmp_scripts/
.