CTSM5.2 1979 fsurdat and 1979-2026 landuse ne0np4 files #2490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slevis-lmwg
added
enhancement
|
@slevis-lmwg you could rebase this to b4b-dev as the timeline for this one could be in cesm2_3_beta17 or in cesm2_3_beta18. But, up to you... |
slevis-lmwg
commented
Apr 26, 2024
slevis-lmwg
commented
Apr 26, 2024
ekluzek
removed
the
priority: Immediate
slevis-lmwg
commented
Apr 30, 2024
|
This will likely come in with cesm2_3_beta17, but in CSEG we decided it coming in with cesm2_3_beta18 (before May 10th) is OK. |
slevis-lmwg
commented
Apr 30, 2024
...which I generated manually one at a time
ekluzek
requested changes
May 7, 2024
There was a problem hiding this comment.
I looked it over and finished the questions that I needed to provide an answer for. There are some changes needed.
Other than that it looks great. Thanks for getting this together quickly. I'm changing this out of draft mode.
I'll learn in the CSEG meeting if we want this in for beta17 or not, and let you know...
slevis-lmwg
added
PR status: ready
ekluzek
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Generate files and add infrastructure for them as explained below.
Specific notes
Contributors other than yourself, if any:
@ekluzek
CTSM Issues Fixed (include github issue #):
Fixes #2487
Are answers expected to change (and if so in what way)?
No
Any User Interface Changes (namelist or namelist defaults changes)?
Also listed in the issue #2487:
Adding 3 fsurdat and 3 landuse files to namelist defaults.
Adding testing for these to the ctsm_sci test-suite.
Adding these to mksurfdata_esmf so that they will be generated with
make all.Testing performed, if any:
Planned testing is listed in the issue #2487.