-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix and improve anomaly forcings for ISSP cases #292
base: main
Are you sure you want to change the base?
Conversation
cdeps1.0.34
@ekluzek, a few questions:
<default_value>''</default_value>
<value compset="^SSP126_">Anomaly.Forcing.cmip6.ssp126</value> |
@samsrabin is this ready- if not can you make it a draft please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not clear to me that anomaly_forcing will always be defined and be an array.
This reverts commit 3f36622b3bd6358d324f1aca5e90009db306963e, which tried to do this in namelist_definition_datm.xml, and instead does it in datm/cime_config/buildnml. Only looks at compset if anomaly_forcing not specified in namelist.
…rounding quote marks.
Force-pushed to remove premature merge of main into this branch, which was interfering with my testing. |
@ekluzek This is ready, if you'd like to review! |
Note that this is up-to-date with cdeps1.0.34. If you'd like me to merge in the latest tag, let me know and I'll redo the testing. |
Description of changes
Fixes a bug, and also makes it much simpler to run land-only SSP cases.
Specific notes
Contributors other than yourself, if any: @ekluzek
CDEPS Issues Fixed (include github issue #):
Are there dependencies on other component PRs (if so list): This doesn't depend on other components. However, I will soon submit a PR to CTSM that depends on this branch. (See issue ESCOMP/CTSM#2301.)
Are changes expected to change answers (bfb, different to roundoff, more substantial): Substantial, but only if people were being bitten by #258 before.
Any User Interface Changes (namelist or namelist defaults changes): Yes.
Adds
anomaly_forcing
options:Anomaly.Forcing.cmip5.rcp45
Anomaly.Forcing.cmip6.ssp126
Anomaly.Forcing.cmip6.ssp245
Anomaly.Forcing.cmip6.ssp370
Anomaly.Forcing.cmip6.ssp585
Removes all variable-specific
anomaly_forcing
options.Testing performed (e.g. aux_cdeps, CESM prealpha, etc):
datm_ssp126_anom_forc
, is bit-for-bit identical to previous version (ctsm5.2.015
).aux_cdeps
test of SSP585 compset, added the 3 other SSP compsets. Allaux_cdeps
SSP tests show diffs as expected fromcdeps1.0.34
.Hashes used for testing:
Remaining work
anomaly_forcing
is automatically set for eachISSP
compsetI
SSP
compset to test) Ensure that it's only set forDATM
compsetsanomaly_forcing
in the generateddatm_in
: Fix that. (Note that the anomaly forcing file IS correctly being put indatm.streams.xml
.)