add ccd=0

[zywshoon]

add ccd =0 will cause the coagulation slightly different than before.

these are the tests didn't pass regression test because they all have coagulation processes on. Let me know how you want me to process.

** Starting FRACTALMICROTEST.exe at Wed Aug 14 14:51:45 MDT 2024 **
Fractal Test
Done
** Finished at Wed Aug 14 14:51:55 MDT 2024 **

  carma_fractalmicrotest.txt differs from benchmark file ../../tests/bench/carma_fractalmicrotest.txt      

** Starting SULFATETEST.exe at Wed Aug 14 14:52:02 MDT 2024 **
Sulfate Test
** Finished at Wed Aug 14 14:52:02 MDT 2024 **

  carma_sulfatetest.txt differs from benchmark file ../../tests/bench/carma_sulfatetest.txt 

** Starting SULFATE_VEHKAMAKI_TEST.exe at Wed Aug 14 14:52:02 MDT 2024 **
Sulfate Test
** Finished at Wed Aug 14 14:52:02 MDT 2024 **

  carma_sulfate_vehkamaki_test.txt differs from benchmark file ../../tests/bench/carma_sulfate_vehkamaki_test.txt   

** Starting SULFHETTEST.exe at Wed Aug 14 14:52:02 MDT 2024 **
Sulfate Heterogeneous Test
** Finished at Wed Aug 14 14:52:02 MDT 2024 **

  carma_sulfhettest.txt differs from benchmark file ../../tests/bench/carma_sulfhettest.txt      

** Starting SULFHET_VEHKAMAKI_TEST.exe at Wed Aug 14 14:52:02 MDT 2024 **
Sulfate Heterogeneous Test
** Finished at Wed Aug 14 14:52:02 MDT 2024 **

  carma_sulfhet_vehkamaki_test.txt differs from benchmark file ../../tests/bench/carma_sulfhet_vehkamaki_test.txt    

[zywshoon]

I changed the tab problem.

[tilmes]

This looks good to me, Simone

[fvitt]

If this changes results then the baselines stored in the stand-alone carma repo will need updated.

[cbardeen]

I am not sure this change gives you the right granularity for turning it on and off. If you had a mixed cloud and aerosol model, wouldn't you want to include this in the cloud-aerosol interactions, but not in the aerosol-aerosol or cloud-cloud interactions. This flag always has them either on or off for all groups (particle types). Perhaps it should be a flag on AddCoagulation() so that it can be kept per coagulation interaction. Perhaps something similar to use_vw(group1, group2). For example, if (use_ccd(j1,j2))then ...

[zywshoon]

I am not sure this change gives you the right granularity for turning it on and off. If you had a mixed cloud and aerosol model, wouldn't you want to include this in the cloud-aerosol interactions, but not in the aerosol-aerosol or cloud-cloud interactions. This flag always has them either on or off for all groups (particle types). Perhaps it should be a flag on AddCoagulation() so that it can be kept per coagulation interaction. Perhaps something similar to use_vw(group1, group2). For example, if (use_ccd(j1,j2))then ...

should I define it as cstate%f_ variable or carma%f_ variable?

[cbardeen]

It can be part of CARMA, since in is known at configuration time and is independent of the model state. Sent from my iPhoneOn Sep 4, 2024, at 4:08 PM, zywshoon ***@***.***> wrote: I am not sure this change gives you the right granularity for turning it on and off. If you had a mixed cloud and aerosol model, wouldn't you want to include this in the cloud-aerosol interactions, but not in the aerosol-aerosol or cloud-cloud interactions. This flag always has them either on or off for all groups (particle types). Perhaps it should be a flag on AddCoagulation() so that it can be kept per coagulation interaction. Perhaps something similar to use_vw(group1, group2). For example, if (use_ccd(j1,j2))then ... should I define it as cstate%f_ variable or carma%f_ variable? —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because your review was requested.Message ID: ***@***.***>

[tilmes]

Is there a paper we can reference here?

[zywshoon]

I haven't found any

[cbardeen]

It doesn't seem correct for use_ccd to be dimensioned(NGROUP, NGROUP) and be part of the element data. Element data should be dimensions NELEMENT by something. If this is really decided at the group level, then it should be part of the group section above. If it is part of the element, then it should have NELEMENT dimensions. I assume you should just move it up to the group section.