-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cam6_3_132: Changes to capture changes made in run 51 #900
Merged
cacraigucar
merged 14 commits into
ESCOMP:cam_development
from
cacraigucar:cam_match_run_51
Oct 18, 2023
Merged
Changes from 5 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
f4ec0be
namelist changes to match run 51
cacraigucar 221dc72
cloud ice fraction changes for cam_dev
adamrher 46b65e2
Merge pull request #16 from adamrher/cam_match_run_51.arh
cacraigucar dd69c5d
added namelists for wsub_min_asf, modified namelist defaults to refle…
adamrher 64f5873
Merge pull request #17 from adamrher/cam.wmixmin
cacraigucar 84a256d
swap cam_dev conditional for a new namelist, remove se gamma namelist…
adamrher 22f5897
Merge pull request #18 from adamrher/cam.aistnl
cacraigucar e28d2bc
Update externals to allow for derecho priority setting
cacraigucar 672aaf1
address review requests
cacraigucar c50fcc6
Change namelist based on verbal request from Adam, Cecile and Peter
cacraigucar 8b7a4ea
Change PE layout to fix some derecho failures
cacraigucar a35cef1
Fix failing SPCAM test
cacraigucar 7139631
Merge tag 'cam6_3_131' into cam_match_run_51
cacraigucar 311a23d
ChangeLog for cam6_3_132
cacraigucar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we remove
<clubb_gamma_coef dyn="se" > 0.270 </clubb_gamma_coef>
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good catch actually because it results in a tie if you run w/ cam_dev and se. We can either do away with it entirely, or specify it further to refer to how se is configured for cam6 in the CESM2.2 JAMES paper:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd seen that and confirmed that the first one appeared to beat out the later one. Can we just delete the
<clubb_gamma_coef dyn="se" phys="cam6" > 0.270 </clubb_gamma_coef>
as it is captured in the CESM2.2 branch for archival purposes?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. Yes, I concur with deleting it entirely from cam_development.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is resolved in PR pending to this branch. Note that removing this line will cause a lot of baseline failures.