Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding first version of the 2.2 exercise #54

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

UndeadFairy
Copy link
Collaborator

No description provided.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@UndeadFairy UndeadFairy changed the title adding first version of the exercise adding first version of the 2.2 exercise Sep 12, 2024
Copy link

review-notebook-app bot commented Sep 13, 2024

View / edit / reply to this conversation on ReviewNB

clausmichele commented on 2024-09-13T07:19:06Z
----------------------------------------------------------------

This part is pretty similar to the previous, could we merge them into a single section?


Copy link

review-notebook-app bot commented Sep 13, 2024

View / edit / reply to this conversation on ReviewNB

clausmichele commented on 2024-09-13T07:19:06Z
----------------------------------------------------------------

I would directly inspect only items[0], otherwise the rendered notebook includes all the items and becomes difficult to read, since there is too much content to scroll.


Copy link

review-notebook-app bot commented Sep 13, 2024

View / edit / reply to this conversation on ReviewNB

clausmichele commented on 2024-09-13T07:19:07Z
----------------------------------------------------------------

Could we merge this part with the previous? For instance, the projection was printed there already.


Copy link

review-notebook-app bot commented Sep 13, 2024

View / edit / reply to this conversation on ReviewNB

clausmichele commented on 2024-09-13T07:19:08Z
----------------------------------------------------------------

I don't think this part fits in here. The lecture is about data properties, not processing. We could consider to reuse the exercise in another lecture.


UndeadFairy commented on 2024-09-19T07:34:46Z
----------------------------------------------------------------

Understand the point, I was also contemplating if it is not too much, but I thought of finishing with some nice visualization (usually students like to see something visual) and as hint what comes next. Maybe just single band visualisation would be better here?

clausmichele commented on 2024-09-19T07:48:52Z
----------------------------------------------------------------

Yes, I think that visualization without particular processing would be fine, especially if it involves using metadata from the file needed for scaling.

@clausmichele
Copy link
Member

@UndeadFairy I left some comments using ReviewNB, I hope you can see them properly.

Copy link
Collaborator Author

Understand the point, I was also contemplating if it is not too much, but I thought of finishing with some nice visualization (usually students like to see something visual) and as hint what comes next. Maybe just single band visualisation would be better here?


View entire conversation on ReviewNB

Copy link
Member

Yes, I think that visualization without particular processing would be fine, especially if it involves using metadata from the file needed for scaling.


View entire conversation on ReviewNB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants