Fix various intergi sites #2867
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
December 9, 2022 11:51
Privacy Badger hasn't detected this as a fingerprinter yet, and I'm still not 100% sure what it does exactly
ghost
marked this pull request as draft
|
Temporarily marking as a draft while I work on reversing the formatting problems caused by Prettier. (The force-push was me merging 3 commits relating to Prettier together into one commit) |
ghost
marked this pull request as ready for review
|
Should be done now. Someone will need to perform more testing than I have the time to do (I am just testing in DevTools/the browser console). |
|
It would really help if you went through the sites you found fixes for in uAssets/etc. and then confirmed/documented the breakage here, and then also verified that this PR fixes the breakage. The more the better of course, but a couple of different examples would already be great. Thank you! |
ghostwords
added
the
surrogates
ghost
closed this by deleting the head repository
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2865, #2847, #2865 (comment), and #2865 (comment)
The difference between this one and #2865 is that I've fixed the problems Prettier caused with the code style, removed fingerprinter-production.herokuapp.com (it doesn't unbreak anything, I'm not 100% sure what it does anyway, and it's not blocked by Privacy Badger yet), and used the code suggested by ghostwords: #2865 (comment)
I have enabled edits by maintainers, so maintainers are welcome to fix any problems in the PR.