Add filter comment and convert object to boolean

EFForg · Jul 2, 2024 · 02e971d · 02e971d
1 parent 3a29a40
commit 02e971d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/skin/css/firstRun.css b/src/skin/css/firstRun.css
@@ -826,6 +826,7 @@ body {
 }
 
 #dismiss-nudge:hover img, #dismiss-nudge:focus img {
+  /* Calculated with https://codepen.io/sosuke/pen/Pjoqqp to match #F06A0A */
   filter: invert(63%) sepia(46%) saturate(6632%) hue-rotate(356deg) brightness(95%) contrast(98%);
 }
 
@@ -922,6 +923,7 @@ body {
   }
 
   #dismiss-nudge:hover img, #dismiss-nudge:focus img {
+    /* Calculated with https://codepen.io/sosuke/pen/Pjoqqp to match #F06A0A */
     filter: invert(63%) sepia(46%) saturate(6632%) hue-rotate(356deg) brightness(95%) contrast(98%);;
   }
 }
diff --git a/src/skin/js/firstRun.js b/src/skin/js/firstRun.js
@@ -45,7 +45,7 @@ $(function () {
   // Don't show the pin nudge in Firefox because extensions are pinned automatically
   // chrome.action is only available in MV3 and chrome.browserAction is only available in <= MV2
   // chrome.browserAction.getUserSettings doesn't exist in MV2 but does in Firefox
-  let is_chromium_mv3 = chrome.action;
+  let is_chromium_mv3 = !!chrome.action;
   let is_chromium_mv2 = chrome.browserAction && !chrome.browserAction.getUserSettings;
   if (is_chromium_mv2 || is_chromium_mv3) {
     $("#pin-nudge-text").html(chrome.i18n.getMessage("intro_pin_nudge", [chrome.i18n.getMessage("popup_disable_for_site")]));