Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i#5036 A64 scatter/gather, part 10: Non-fault loads #6756

Merged
merged 4 commits into from
Apr 8, 2024

Conversation

jackgallagher-arm
Copy link
Collaborator

Adds support for non-fault loads to drx_expand_scatter_gather(). Non-fault loads (ldnf1*) work similarly to scalar+immediate predicated contiguous ld1* loads, but with different behaviour if an element access faults. This commit implements this behaviour and extends the scatter/gather tests to include ldnf1* instructions.

Issue: #5036

Adds support for non-fault loads to drx_expand_scatter_gather().
Non-fault loads (ldnf1*) work similarly to scalar+immediate predicated
contiguous ld1* loads, but with different behaviour if an element
access faults. This commit implements this behaviour and extends the
scatter/gather tests to include ldnf1* instructions.

Issue: #5036
@jackgallagher-arm
Copy link
Collaborator Author

client.detach_test is timing out repeatedly on the vs2019-32 build. I can't see anything in this patch which would affect that test so I suspect the failure is spurious.

201/262 Test #131: code_api|client.detach_test ..................................***Timeout  90.02 sec

@AssadHashmi AssadHashmi merged commit 59a2c38 into master Apr 8, 2024
15 of 16 checks passed
@AssadHashmi AssadHashmi deleted the i5036-aarch64-scatter-gather-part-10-ldnf branch April 8, 2024 12:35
@derekbruening
Copy link
Contributor

client.detach_test is timing out repeatedly on the vs2019-32 build. I can't see anything in this patch which would affect that test so I suspect the failure is spurious.

201/262 Test #131: code_api|client.detach_test ..................................***Timeout  90.02 sec

As with any test failure, please file a bug and cite it here or cite an existing bug if one is already filed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants