i#6599: Relax WOW64 drmemtrace syscall invariant #6732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relaxes a drmemtrace syscall invariant for WOW64 where raw2trace delays the "syscall" call across the 2nd set of timestamp;cpuid markers, breaking the drmemtrace invariant checker. A full solution requires #5949 to actually identify the syscall as such: the relaxations for this and prior changes are marked under that issue and will be removed when it is addressed, so we can consider Issue: #5949, $6599 Fixes #6599
derekbruening
requested review from
xdje42 and
ivankyluk
and removed request for
xdje42
ivankyluk
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relaxes a drmemtrace syscall invariant for WOW64 where raw2trace delays the "syscall" call across the 2nd set of timestamp;cpuid markers, breaking the drmemtrace invariant checker.
A full solution requires #5949 to actually identify the syscall as such: the relaxations for this and prior changes are marked under that issue and will be removed when it is addressed, so we can consider #6599 closed.
Tested manually on WOW64 where the tool.record_filter and tool.record_filter_bycore_uni tests fail reliably without this fix and pass with it.
Issue: #5949, #6599
Fixes #6599