i#6678 Rename aarchxx workflows, part 1: ci-aarchxx -> ci-aarchxx-cross #6696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are currently two workflows name "ci-aarchxx" which is confusing. The ci-aarch64-native workflow was renamed to ci-aarchxx in #6549 with the goal of being consistent with other architecture workflows. However, this introduced the ambiguous "ci-aarchxx" naming. Fix this by renaming ci-aarchxx.yml -> ci-aarchxx-cross.yml, and renaming ci-aarch64-native.yml -> ci-aarchxx.yml. Furthermore, rename the aarchxx "cross" workflow to ci-aarchxx-cross. This accomplishes three things: 1) Naming is consistent with the other workflow files: native workflows are named "ci-$ARCH" and live in file "ci-$ARCH.yml". 2) All workflows have unique names. 3) The yml file and workflow have the same name. In this part one we rename the cross ci-aarchxx to ci-aarchxx-cross, in the workflow name and yml file name. In part two to follow (#xyz) we will leave the workflow name alone, but still rename the file from ci-aarch64-native.yml to ci-aarchxx.yml. The renaming is split into two to better preserve the history: Git can track file renamings, but not when the original file is also replaced with something different. Issue #6678
joshua-warburton
approved these changes
Mar 8, 2024
xdje42
added a commit
that referenced
this pull request
Mar 13, 2024
… file There are currently two workflows name "ci-aarchxx" which is confusing. The ci-aarch64-native workflow was renamed to ci-aarchxx in #6549 with the goal of being consistent with other architecture workflows. However, this introduced the ambiguous "ci-aarchxx" naming. Fix this by renaming ci-aarchxx.yml -> ci-aarchxx-cross.yml, and renaming ci-aarch64-native.yml -> ci-aarchxx.yml. Furthermore, rename the aarchxx "cross" workflow to ci-aarchxx-cross. This accomplishes three things: 1) Naming is consistent with the other workflow files: native workflows are named "ci-$ARCH" and live in file "ci-$ARCH.yml". 2) All workflows have unique names. 3) The yml file and workflow have the same name. In part one (#6696) we renamed the cross ci-aarchxx to ci-aarchxx-cross, in the workflow name and yml file name. In this part two we leave the workflow name alone, but still rename the file from ci-aarch64-native.yml to ci-aarchxx.yml. The renaming is split into two to better preserve the history: Git can track file renamings, but not when the original file is also replaced with something different. Fixes #6678
xdje42
added a commit
that referenced
this pull request
Mar 13, 2024
#6705) There are currently two workflows name "ci-aarchxx" which is confusing. The ci-aarch64-native workflow was renamed to ci-aarchxx in #6549 with the goal of being consistent with other architecture workflows. However, this introduced the ambiguous "ci-aarchxx" naming. Fix this by renaming ci-aarchxx.yml -> ci-aarchxx-cross.yml, and renaming ci-aarch64-native.yml -> ci-aarchxx.yml. Furthermore, rename the aarchxx "cross" workflow to ci-aarchxx-cross. This accomplishes three things: 1) Naming is consistent with the other workflow files: native workflows are named "ci-$ARCH" and live in file "ci-$ARCH.yml". 2) All workflows have unique names. 3) The yml file and workflow have the same name. In part one (#6696) we renamed the cross ci-aarchxx to ci-aarchxx-cross, in the workflow name and yml file name. In this part two we leave the workflow name alone, but still rename the file from ci-aarch64-native.yml to ci-aarchxx.yml. The renaming is split into two to better preserve the history: Git can track file renamings, but not when the original file is also replaced with something different. Fixes #6678
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are currently two workflows name "ci-aarchxx" which is confusing. The ci-aarch64-native workflow was renamed to ci-aarchxx in #6549 with the goal of being consistent with other architecture workflows. However, this introduced the ambiguous "ci-aarchxx" naming.
Fix this by renaming ci-aarchxx.yml -> ci-aarchxx-cross.yml, and renaming ci-aarch64-native.yml -> ci-aarchxx.yml.
Furthermore, rename the aarchxx "cross" workflow to ci-aarchxx-cross.
This accomplishes three things:
In this part one we rename the cross ci-aarchxx to ci-aarchxx-cross, in the workflow name and yml file name.
In part two to follow (#6697) we will leave the workflow name alone, but still rename the file from ci-aarch64-native.yml to ci-aarchxx.yml. The renaming is split into two to better preserve the history: Git can track file renamings, but not when the original file is also replaced with something different.
Issue #6678