i#6635 core filter, part 3: record_scheduler_t switch boundaries #6695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For record_scheduler_t, context switch on encoding boundaries instead of instruction boundaries to avoid splitting up encodings from their instructions. We end up not supporting unread_last_record() for record_scheduler_t as we do not have the pre-prev record to identify a first encoding in a sequence. Adds a unit test. Inserting synthetic tid,pid records so the switches are actually visible will be added separately. Issue: #6635
…ull into this separate PR)
abhinav92003
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For record_scheduler_t, context switch on encoding boundaries instead of instruction boundaries to avoid splitting up encodings from their instructions.
We end up not supporting unread_last_record() for record_scheduler_t as we do not have the pre-prev record to identify a first encoding in a sequence.
Adds a unit test.
Inserting synthetic tid,pid records so the switches are actually visible will be added separately.
Issue: #6635