i#6666: Avoid hang when analyzer worker returns early #6667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a call to set_active(false) on the output stream when an analyzer worker thread returns early due to an error. This frees up the current input and avoids a hang in the scheduler after the error is printed. Adds a unit test which hangs without this fix. Fixes #6666
abhinav92003
requested changes
Feb 21, 2024
abhinav92003
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a call to set_active(false) on the output stream when an analyzer worker thread returns early due to an error. This frees up the current input and avoids a hang in the scheduler after the error is printed.
Adds a unit test which hangs without this fix.
Fixes #6666