i#6662 public traces, part 2: encoding_filter #6663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simple record_filter_t::record_filter_func_t filter that modifies a field of every trace_entry_t record in a trace and leverages record_filter to output such modified records onto a "filtered" output trace. Issue: #6662
edeiana
changed the title
encoding_filter.h changes instr length and pc in this commit, but does not change branch targets accordingly.
… the check for encoding size vs instruction length in memref_counter_t (which is a reader_t).
in record_filter_launcher.
edeiana
commented
Apr 25, 2024
edeiana
commented
Apr 25, 2024
Now checking return value after encode.
more precise encodings2regdeps.
on x86_64 only for various reasons).
Returning the same name as other arches (i.e., "<invalid>", "<undecoded>").
edeiana
commented
May 2, 2024
edeiana
commented
May 2, 2024
derekbruening
approved these changes
May 4, 2024
trace_entry_t records than regdeps ISA encoding.
for consistency with other filters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New record_filter_t::record_filter_func_t filter, which we call "encodings2regdeps", that modifies the encoding of
trace_entry_t records from a real ISA to the synthetic regdeps ISA.
"encodings2regdeps" can add or remove trace_entry_t records that contain encodings depending on the regdeps
encoding size. Note that "encodings2regdeps" only changes the encoding of instructions, but it does not adjust
their length (or changes the instruction PC), hence the output trace will have encoding sizes that do not match the
instruction length. For this reason we disable the encoding size vs instruction length check in reader_t when the
trace has DR_ISA_REGDEPS encodings.
This filter is part of the "record_filter" tool and can be invoked with:
Issue: #6662