i#6643: Support drmemtrace analysis for #instr intervals #6644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support to produce trace interval results in the drmemtrace analyzer framework where the intervals are defined as count of instrs. Unlike the timestamp (microseconds) based intervals where we support merging the per-shard intervals generated during parallel mode to create whole-trace intervals, for the #instr intervals we do not support merging. This is because merging #instr intervals is non-trivial. See added XXX comment for details. Extends the trace_interval_analysis_unit_tests to test the new feature. Also adds a basic_counts test that uses #instr intervals. Issue: #6643
abhinav92003
changed the title
brettcoon
reviewed
Feb 9, 2024
clients/drcachesim/tests/trace_interval_analysis_unit_tests.cpp
Outdated
Show resolved
Hide resolved
…ine_interval_snapshots() calls where not needed. Also some renaming to better readability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support to produce trace interval results in the drmemtrace analyzer framework where the intervals are defined by a count of instrs. This is enabled using the new -interval_instr_count flag.
Unlike the timestamp (microseconds) based intervals where we support merging the per-shard intervals generated during parallel mode to create whole-trace intervals, for the #instr intervals we do not support merging. This is because merging #instr intervals is non-trivial. See added TODO comment for current ideas to achieve that in future. In the current version, when trace analysis completes, the print_interval_results() API is called separately for each shard with the interval state snapshots of that shard.
Extends the trace_interval_analysis_unit_tests to test the new feature. Also adds a basic_counts test that uses #instr intervals.
Modifies some existing logic to skip invoking the combine_interval_snapshots API in the serial mode. This way the user can avoid implementing the API if they're interested only in the serial mode.
Unnests some nested structs in trace_interval_analysis_unit_tests to shorten some struct identifiers frequently used to create expected test output objects. This helps fit some expected output entries in one line, making it easier to read.
Issue: #6643