i#6524: Fix udivmoddi4.c 32-bit linux build fail and semantics #6526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SI mode in GCC is 32 bits, regardless of architecture, and DI mode is 64 bits. Previously __moddi3 was working with 32 bit arguments and returning a 32 bit result. Changed to work with 64 bit values. Fixes: #6524
…ivmoddi4-build-fail
xdje42
changed the title
xdje42
changed the title
xdje42
changed the title
abhinav92003
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the targets we care about LIBGCC2_UNITS_PER_WORD == 4 (SImode in GCC parlance).
Thus a double word is 8 bytes (DImode in GCC parlance).
Previously, __moddi3 was using a mix of word and double word widths,
causing a compilation failure on 32 bit linux with the Debian 13.2.0-4 compiler.
The semantics were also incorrect: inputs and outputs should be 64 bits for the
hosts we care about (x86, aarch, 32 and 64 bit, and riscv64).
Fixes: #6524