i#5994 opcode_mix, part1: add categories to opcode_mix output #6512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Groups instructions that belong to the same categories together, and prints (to std::cerr) a count of them at the end of opcode counts. Issue: #5994
executed instruction.
Category names are now space separated.
for opcode and category cache.
32 bits (i.e., all possible categories an instruction can belong to). This way we have single point of control in core/ir/instr_shared.c to assign a name for a new category.
instr_get_category_name().
derekbruening
approved these changes
Jan 22, 2024
and uncategorized instruction (OP_in).
derekbruening
approved these changes
Jan 23, 2024
we are now including tools.h .
derekbruening
approved these changes
Jan 24, 2024
The number of characters that were compared was always 8 (sizeof(category_names[i]) == sizeof(char*)), now using strlen().
of instr_get_category_name() api.
for debugging purposes.
(hopefully in the right place this time).
Moved run position after set() for unrelated opcode_mix test. Enforced order on opcode and categories when printed for consistency in expected output.
Undo tmate changes.
Only for x86_64 Linux, since the tested program is allasm_x86_64.
|
Test opcode_categories fixed. |
derekbruening
approved these changes
Feb 7, 2024
Now that we have temporary variables we need scopes,
used the do { ... } while (0); trick.
encode() and decode() return byte* not byte. Fixed.
function of opcode_mix_t.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Groups instructions that belong to the same categories together, and prints (to std::cerr) a count of them at the end of opcode counts.
Issue: #5994