i#6344 record_syscall: Record return values and add failure marker #6378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes what the drmemtrace -record_syscall feature does with system call returns to record the actual value instead of the success boolean. Adds a new TRACE_MARKER_TYPE_SYSCALL_FAILED to indicate failure. Adds a sanity test to allasm-repstr (and updates other tests that have hardcoded counts for this app). Adds documentation on the change. Issue: #6344
|
Failure is api.rseq failed to synch #6185, yet again -- this is becoming quite frequent. |
abhinav92003
approved these changes
Oct 19, 2023
…nale for always including; update docs, comments, and asm formatting.
|
Failure is (yet again) api.rseq failed to synch #6185 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes what the drmemtrace -record_syscall feature does with system call returns to record the actual value instead of the success boolean. Adds a new TRACE_MARKER_TYPE_SYSCALL_FAILED to indicate failure.
Adds a sanity test to allasm-repstr (and updates other tests that have hardcoded counts for this app).
Adds documentation on the change.
Issue: #6344