-
Notifications
You must be signed in to change notification settings - Fork 561
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
i#6721: Read ahead in as-traced drmemtrace mode
Removes the exception for avoiding reading ahead to get the version and filetype for as-traced drmemtrace mode, as we need those values for the record_filter. Adds explicit error checking and error return up front to the record_filter for missing version info. Adjusts the scheduler unit test's record ordinal to account for the new read-ahead. Adds a test with a checked-in trace of hello,world (truncated to make it smaller) that ran on 4 different cores. The test only reproduces the problem if the read-ahead in open_reader() to find the tid is removed, which I did temporarily; I kept the test as it is also a good additional general test of other corner cases. To create a test that always reproduces in our suite we would need to combine a synthetic reader with use of the scheduler in as-traced mode, which none of our unit tests are set up for. The fix was further tested on large inputs in an internal setup which always passes a synthetic reader, where the problem reproduces every time without the fix. Fixes #6721
- Loading branch information
1 parent
781f15e
commit bad26f7
Showing
8 changed files
with
60 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+422 Bytes
clients/drcachesim/tests/drmemtrace.as_traced.x64.tracedir/cpu_schedule.bin.zip
Binary file not shown.
Binary file added
BIN
+158 KB
...esim/tests/drmemtrace.as_traced.x64.tracedir/drmemtrace.simple_app.1674735.1533.trace.zip
Binary file not shown.
Binary file added
BIN
+37 Bytes
clients/drcachesim/tests/drmemtrace.as_traced.x64.tracedir/serial_schedule.bin.gz
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
Output .* entries from .* entries. | ||
Schedule stats tool results: | ||
.* | ||
Core #0 schedule: .* | ||
Core #1 schedule: .* | ||
Core #2 schedule: .* | ||
Core #3 schedule: .* |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters