Addressed PR comments.

DynamoRIO · Mar 21, 2024 · ab65804 · ab65804
1 parent ef8560c
commit ab65804
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/core/ir/synthetic/encode.c b/core/ir/synthetic/encode.c
@@ -52,7 +52,7 @@ encode_to_synth(dcontext_t *dcontext, instr_t *instr, byte *encoded_instr)
     uint encoding = 0;
 
     /* Encode number of destination operands.
-     * Note that a destination operand that is a memory renference, should have its
+     * Note that a destination operand that is a memory renference should have its
      * registers (if any) counted as source operands, since they are being read.
      * We use used_[src|dst]_reg_map to keep track of registers we've seen and avoid
      * duplicates.

diff --git a/suite/tests/api/ir_x86.c b/suite/tests/api/ir_x86.c
@@ -789,7 +789,7 @@ test_instr_encode_and_decode(void *dc, instr_t *instr, uint len_expect,
     instr_destroy(dc, decin);
 }
 
-void
+static void
 get_instr_src_and_dst_registers(instr_t *instr, uint max_num_regs, byte *used_src_reg_map,
                                 byte *used_dst_reg_map)
 {
@@ -833,8 +833,6 @@ get_instr_src_and_dst_registers(instr_t *instr, uint max_num_regs, byte *used_sr
                 used_src_reg_map[reg] = 1;
         }
     }
-
-    return;
 }
 
 bool