Skip to content

Commit

Permalink
Update instructions for how to watch merges to master
Browse files Browse the repository at this point in the history
  • Loading branch information
xdje42 committed Feb 10, 2024
1 parent 33791c0 commit 8a4f74a
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions api/docs/triager.dox
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,10 @@
We have a rotating Triager who is responsible for monitoring our continuous testing infrastructure and for triaging incoming requests from users. Specific duties include:

- Ensure that our Continuous Integration testing through Github Actions are operating smoothly.
- Do this by going to the Github Actions page: https://github.com/DynamoRIO/dynamorio/actions.
- Do this by going to the Github Actions page: https://github.com/DynamoRIO/dynamorio/actions. Look for red Xs and in those failing builds watch for flaky tests.
- If flaky tests are failing too often, assign someone to fix them ASAP, or mark them to be ignored in `runsuite_wrapper.pl`.
- Watch merges to master for failures on the longer test suite.
- Do this by watching for merges on the dynamorio-devs@ list.
- Do this by going to the Github Actions page for the master branch: https://github.com/DynamoRIO/dynamorio/actions?query=branch%3Amaster. Look for red Xs and investigate any failures found.
- File an issue on previously-unknown failures, or update existing issues for repeats. Consider marking tests as flaky in `runsuite_wrapper.pl` if they are keeping the master merge red.
- Answer (or request that someone else who is more of an expert in that area answer) incoming dynamorio-users emails.
- Sometimes emails to the list are marked as spam, so it is a good idea to directly watch the web interface: https://groups.google.com/g/DynamoRIO-Users
Expand Down

0 comments on commit 8a4f74a

Please sign in to comment.