Skip to content

Commit

Permalink
Restore msgbox_mask package defaults
Browse files Browse the repository at this point in the history
Replaces the AUTOMATED_TESTING set in package builds by PR #2474 with
the new DISABLE_ZLIB CMake option added by
DynamoRIO/dynamorio#7030. This fixes a regression where msgbox_mask
was set to 0 by default in packages, which caused many users to fail
to obtain error information and has led to confusion with silent
errors.

Fixes DynamoRIO/dynamorio#7025
  • Loading branch information
derekbruening committed Oct 9, 2024
1 parent 384f6aa commit d1cb060
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions package.cmake
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# **********************************************************
# Copyright (c) 2010-2022 Google, Inc. All rights reserved.
# Copyright (c) 2010-2024 Google, Inc. All rights reserved.
# Copyright (c) 2009-2010 VMware, Inc. All rights reserved.
# **********************************************************

Expand Down Expand Up @@ -136,7 +136,7 @@ set(base_cache "
UNIQUE_BUILD_NUMBER:STRING=${arg_ubuild}
BUILD_TOOL_TESTS:BOOL=OFF
BUILDING_PACKAGE:BOOL=ON
AUTOMATED_TESTING:BOOL=ON
DISABLE_ZLIB:BOOL=ON
${sub_entry}
${arg_cacheappend}
${base_cache}
Expand Down

0 comments on commit d1cb060

Please sign in to comment.