-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump requirements, fix tests and add get tentacles dict #140
base: master
Are you sure you want to change the base?
Conversation
Once this test is passing, we can merge it ! |
Head branch was pushed to by a user without write access
e02f471
to
4676fb1
Compare
Looks like its an issue happening only on linux, here on my windows its passing all tests. |
@@ -26,6 +26,26 @@ def get_installed_tentacles_modules() -> set: | |||
return set(tentacle for tentacle in loaders.get_tentacle_classes().values()) | |||
|
|||
|
|||
def get_installed_tentacles_modules_dict() -> dict: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What will it be used for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this can be used with the react ui to manage installed tentacles
meanwhile i moved it to the react ui
I also updated the pull request - I removed create folder if it doesnt exist as its already fixed in master
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why can't you use get_installed_tentacles_modules
to do it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its returning as a set and tentacle_type is an object which doesnt work with json without changing it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not converting to json in client (caller) side?
def get_installation_context_octobot_version() -> dict: | ||
setup_config = configuration.TentaclesSetupConfiguration() | ||
available_tentacle = util.load_tentacle_with_metadata(constants.TENTACLES_PATH) | ||
setup_config.fill_tentacle_config(available_tentacle, constants.TENTACLE_CONFIG_FILE_NAME) | ||
return setup_config.installation_context |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
74d8401
to
e72ae6c
Compare
regarding your questions:
|
a4659f5
to
474a8b9
Compare
No description provided.