bump requirements, fix tests and add get tentacles dict #140
Conversation
|
Once this test is passing, we can merge it ! |
Head branch was pushed to by a user without write access
techfreaque
force-pushed
the
master
branch
2 times, most recently
from
e02f471
to
4676fb1
Compare
Looks like its an issue happening only on linux, here on my windows its passing all tests. |
| @@ -26,6 +26,26 @@ def get_installed_tentacles_modules() -> set: | |||
| return set(tentacle for tentacle in loaders.get_tentacle_classes().values()) | |||
|
|
|||
|
|
|||
| def get_installed_tentacles_modules_dict() -> dict: | |||
There was a problem hiding this comment.
this can be used with the react ui to manage installed tentacles
meanwhile i moved it to the react ui
I also updated the pull request - I removed create folder if it doesnt exist as its already fixed in master
There was a problem hiding this comment.
Why can't you use get_installed_tentacles_modules to do it?
There was a problem hiding this comment.
its returning as a set and tentacle_type is an object which doesnt work with json without changing it
There was a problem hiding this comment.
Why not converting to json in client (caller) side?
techfreaque
changed the title
| def get_installation_context_octobot_version() -> dict: | ||
| setup_config = configuration.TentaclesSetupConfiguration() | ||
| available_tentacle = util.load_tentacle_with_metadata(constants.TENTACLES_PATH) | ||
| setup_config.fill_tentacle_config(available_tentacle, constants.TENTACLE_CONFIG_FILE_NAME) | ||
| return setup_config.installation_context |
techfreaque
force-pushed
the
master
branch
4 times, most recently
from
74d8401
to
e72ae6c
Compare
|
regarding your questions:
|
techfreaque
force-pushed
the
master
branch
2 times, most recently
from
a4659f5
to
474a8b9
Compare
No description provided.