Brighter colours when coloured icons is on #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
app/src/main/java/io/github/domi04151309/alwayson/services/NotificationService.kt
Fixed
Show fixed
Hide fixed
app/src/main/java/io/github/domi04151309/alwayson/services/NotificationService.kt
Fixed
Show fixed
Hide fixed
app/src/main/java/io/github/domi04151309/alwayson/services/NotificationService.kt
Fixed
Show fixed
Hide fixed
rlees85
changed the title
|
I think this is as tidy as I can get it. The coloured notifications option is fairly useless without it IMO hence why I didn't include a setting option (but I can do). I'm also not sure why one of the checks are failing, doesn't seem to have any output. Let me know what you think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #96
This is another change I have been running that may need to go behind a setting if you wanted to implement it into the app. It makes the "coloured icons" option look much much nicer on the black background.
Its one of those you'd have to run and see it for yourself but in my opinion the coloured icons option wasn't usable before.
Feel free to contribute to this PR especially as the code is fairly bad (probably) 😁