Don't report when entries with multiple conditions and trailing comma

Doist · Sep 13, 2024 · a6c563a · a6c563a
1 parent 59dc3c9
commit a6c563a
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 1 deletion.
diff --git a/src/main/kotlin/com/doist/detekt/ConsistentWhenEntries.kt b/src/main/kotlin/com/doist/detekt/ConsistentWhenEntries.kt
@@ -33,5 +33,5 @@ class ConsistentWhenEntries(config: Config) : Rule(config) {
         }
     }
 
-    private fun KtWhenEntry.isMultiline() = text.count { it == '\n' } > 1
+    private fun KtWhenEntry.isMultiline() = (expression?.text?.count { it == '\n' } ?: 0) > 1
 }
diff --git a/src/test/kotlin/com/doist/detekt/ConsistentWhenEntriesTest.kt b/src/test/kotlin/com/doist/detekt/ConsistentWhenEntriesTest.kt
@@ -53,4 +53,38 @@ internal class ConsistentWhenEntriesTest(private val env: KotlinCoreEnvironment)
         val findings = rule.compileAndLintWithContext(env, code)
         findings shouldHaveSize 0
     }
+
+    @Test
+    fun `doesn't report single line when entries with multiple conditions and trailing comma`() {
+        val code = """
+            val a = listOf<Int>()
+            val b = when(a) {
+                is ArrayList,
+                is MutableList,
+                -> true
+                else -> false
+            }
+        """
+        val rule = ConsistentWhenEntries(Config.empty)
+        val findings = rule.compileAndLintWithContext(env, code)
+        findings shouldHaveSize 0
+    }
+
+    @Test
+    fun `report inconsistent when entries with multiple conditions and trailing comma`() {
+        val code = """
+            val a = listOf<Int>()
+            val b = when(a) {
+                is ArrayList,
+                is MutableList,
+                -> {
+                    true
+                }
+                else -> false
+            }
+        """
+        val rule = ConsistentWhenEntries(Config.empty)
+        val findings = rule.compileAndLintWithContext(env, code)
+        findings shouldHaveSize 1
+    }
 }