Merge pull request #677 from DirectoryTree/BUG-676

Bug 676 - Missing return type findManyBy()
DirectoryTree · Jan 9, 2024 · da3d5df · da3d5df
2 parents 617102c + a8dd2a3
commit da3d5df
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/Query/Builder.php b/src/Query/Builder.php
@@ -764,7 +764,7 @@ public function findMany(array|string $dns, array|string $columns = ['*']): Coll
     /**
      * Finds many records by the specified attribute.
      */
-    public function findManyBy(string $attribute, array $values = [], array|string $columns = ['*']): Collection
+    public function findManyBy(string $attribute, array $values = [], array|string $columns = ['*']): Collection|array
     {
         $query = $this->select($columns);
 

diff --git a/src/Query/Model/Builder.php b/src/Query/Model/Builder.php
@@ -160,6 +160,14 @@ public function findMany(array|string $dns, array|string $columns = ['*']): Coll
         return parent::findMany($dns, $columns);
     }
 
+    /**
+     * {@inheritDoc}
+     */
+    public function findManyBy(string $attribute, array $values = [], array|string $columns = ['*']): Collection
+    {
+        return parent::findManyBy($attribute, $values, $columns);
+    }
+
     /**
      * Finds a record using ambiguous name resolution.
      */