Only check if the model contains any changes if no argument was provided

DirectoryTree · Oct 6, 2023 · d0ff61a · d0ff61a
1 parent 355453a
commit d0ff61a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/Models/Concerns/HasAttributes.php b/src/Models/Concerns/HasAttributes.php
@@ -923,7 +923,7 @@ public function discardChanges(): static
      */
     public function wasChanged(array|string $attributes = null): bool
     {
-        if (empty($attributes)) {
+        if (func_num_args() === 0) {
             return count($this->changes) > 0;
         }
 

diff --git a/tests/Unit/Models/ModelTest.php b/tests/Unit/Models/ModelTest.php
@@ -340,11 +340,12 @@ public function test_changed_attributes()
 
         $model->syncChanges();
 
+        $this->assertFalse($model->wasChanged(''));
+        $this->assertFalse($model->wasChanged([]));
         $this->assertFalse($model->wasChanged('foo'));
         $this->assertFalse($model->wasChanged(['foo']));
 
         $this->assertTrue($model->wasChanged());
-        $this->assertTrue($model->wasChanged([]));
         $this->assertTrue($model->wasChanged('bar'));
         $this->assertTrue($model->wasChanged('baz'));
         $this->assertTrue($model->wasChanged(['bar', 'baz']));