Simple generator for ID numbers #772
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e.g. in Georgia it's sufficient to have 11-digit random number)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
In some instances, id_number.valid does not need to have much logic. So, in addition of having separate classes like SvSEIdNumber, we suggest supporting expressions like below too:
id_number:valid: ['0##########', '1##########' ]E.g., in Georgia it's safe to just produce 11-digit random number for testing purposes, since there is no exact algorithm known for these 11-digit numbers anyway and usually nobody makes any assumption regarding these digits. What we know for sure is that it can start with zero too, number does not contain any personal data, it has check digit with unknown algorithm and so on (Source: Order of the Minister of Justice, https://matsne.gov.ge/ka/document/view/1435931 - in Georgian).