-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding powerd by Vercel to footer and readme.md #210
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Linting / Type error - remove passHref and built locally.
|
If it comes to it, I guess we can have a partners | sponsors section to contain the logo. They all don't have to be in the footer. |
Hi @kempsterrrr !
Also in the docs suggests to explicity set the Image width and height With the Link component from chakra you can use the "as" prop like it's used before, for example in the Privacy Policy link:
Let me know if you need some help with this! |
Agreed, particularly after chatting with @elPiablo - for Vercel it must be in the footer and the repo as they're dictating the terms to us. For our partners, we can be in control of those. -- Thanks @Markkos89 - I'll try to find some time to update this PR today. I'll also add the required Logo in the readme.md file which I missed as well - thanks for the tips. Tailwind > Chakra 😝 |
@kempsterrrr is attempting to deploy a commit to the Developerdao Team on Vercel. A member of the Team first needs to authorize it. |
I pushed an update but think I was being stupid and still used the Chakra UI Image component. I also was not sure where to add the Vercel button to the readme.md file - maybe just a supports section at the bottom is good for now? I'm really short on time so wont be able to look at this again until next week. If someone else wants to close out the PR then that's totally fine with me |
Hey @kempsterrrr kemps! Do you want me to change the Image component and also add a |
Just here to support the motion that this is true. Nothing actually beats Tailwind + shadcn rn |
Yes, please. Would really appreciate that as I\m struggling for time 🙏🏻 |
@Markkos89 just pinging you to make sure you got the reply!!! Never quite sure how well GitHub notifications work with/without tagging folks |
Hey Kemps! 🙌 Going to add this to the new branch, it is a small addition so no issue at all. Let me know if this is okey and I will have it the loop. Regards !! 💪 |
Can this PR be closed/rejected if this is being included in another branch @Markkos89 ? |
This PR adds the Vercel logo to the Acamdemy foot per their requirements for sponsoring open-source projects here.
This does open an interesting question. If we also have a logo for the preferred RPC, is that too much or not.