Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to the Organizer #10654

Merged
merged 20 commits into from
Jul 25, 2024
Merged

Updates to the Organizer #10654

merged 20 commits into from
Jul 25, 2024

Conversation

bhollis
Copy link
Contributor

@bhollis bhollis commented Jul 21, 2024

I took a big pass over the Organizer:

  1. String sorting now uses a local-sensitive comparator by default.
  2. You can sort perks columns - they sort by the name of the first perk, and then the name of the second perk, and so on. This should help with exotic class items.
  3. Broke out intrinsics (for armor) into their own column.
  4. Broke out cosmetics (shaders/ornaments) into their own column.
  5. Broke out origin traits into their own column.
  6. Now that everything has its own column, the plain "perks" column is now restricted to perks/mods that don't appear in other columns.
  7. Removed null as an allowed type to return from the value function.
  8. For the deepsight harmonizer column, replaced the checkmark with the deepsight harmonizer icon.
  9. Removed some columns that were not applicable, such as "damage", "crafted", and "breaker" for armor.
  10. Fixed shift-clicking on breaker to fill in a breaker: search.
  11. Widened the "Enabled Columns" menu to multiple columns so it no longer has to scroll.
  12. Perks columns fit their contents instead of having a hardcoded width.
  13. The item type selector no longer scrolls away horizontally.
  14. Updated the text for "no items found".
  15. Added a crappy pager implementation that adds more rows as you scroll. I would've much preferred a real virtual list but the fact that we're using CSS grid for this table makes that very difficult. My solution kinda sucks because the scroll bar jumps as you scroll, but it does prevent your computer from freezing as we render a huge list of items.
  16. As a consequence of having a pager, the "Weapons" tab now shows all weapons by default. Feel free compare sidearms to rocket launchers if that's your thing.
Screenshot 2024-07-21 at 4 59 31 PM Screenshot 2024-07-21 at 4 59 39 PM Screenshot 2024-07-21 at 4 59 27 PM

Copy link
Member

@lowPolySkeleton lowPolySkeleton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bhollis bhollis merged commit 9e14cfc into master Jul 25, 2024
7 checks passed
@bhollis bhollis deleted the organizer-updates branch July 25, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants