Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force initialization of KeyManager on startup #932

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Force initialization of KeyManager on startup #932

merged 1 commit into from
Oct 1, 2024

Conversation

nscuro
Copy link
Member

@nscuro nscuro commented Sep 26, 2024

Description

Forces initialization of KeyManager on startup.

Voids the need for a separate secret key initializer in Docker Compose setups (i.e. https://github.com/DependencyTrack/hyades/blob/348e2c06f901de5b644abb03c863ad546f4894a0/docker-compose.yml#L350-L357), since KeyManager will generate it.

KeyManager was previously only initialized in AlpineServlet (https://github.com/stevespringett/Alpine/blob/7f58a627ed8b476dd780e8b8a1aea14d5a848d7b/alpine-server/src/main/java/alpine/server/AlpineServlet.java#L58-L59), which is not loaded when init.and.exit is enabled.

Also reduce log noise when init.and.exit is enabled.

Addressed Issue

N/A

Additional Details

N/A

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have updated the migration changelog accordingly
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

Voids the need for a separate secret key initializer in Docker Compose setups (i.e. https://github.com/DependencyTrack/hyades/blob/348e2c06f901de5b644abb03c863ad546f4894a0/docker-compose.yml#L350-L357), since `KeyManager` will generate it.

`KeyManager` was previously only initialized in `AlpineServlet` (https://github.com/stevespringett/Alpine/blob/7f58a627ed8b476dd780e8b8a1aea14d5a848d7b/alpine-server/src/main/java/alpine/server/AlpineServlet.java#L58-L59), which is not loaded when `init.and.exit` is enabled.

Also reduce log noise when `init.and.exit` is enabled.

Signed-off-by: nscuro <[email protected]>
@nscuro nscuro added the enhancement New feature or request label Sep 26, 2024
@nscuro nscuro added this to the 5.6.0 milestone Sep 26, 2024
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.03% (target: -1.00%) 18.18% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (a3d83f7) 21977 18161 82.64%
Head commit (f767c93) 21986 (+9) 18161 (+0) 82.60% (-0.03%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#932) 11 2 18.18%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@nscuro nscuro merged commit 4f74749 into main Oct 1, 2024
8 of 9 checks passed
@nscuro nscuro deleted the keymgr-init branch October 1, 2024 14:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants