Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add chain fusion adapter #276

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

NikolasHai
Copy link

This MR adds the following changes:

  1. Bridge adapter for ERC20 <-> ckERC20 Tokens
  2. Bridge adapter for ETH <-> ckETH

@vrtnd
Copy link
Member

vrtnd commented Sep 23, 2024

please add config for your bridge

@NikolasHai
Copy link
Author

please add config for your bridge

Done

@vrtnd
Copy link
Member

vrtnd commented Sep 24, 2024

Need to add destination chain if bridge contains only ethereum <-> icp
or there are more than 2 chains?

target: null,
topic: "Transfer(address,address,uint256)",
abi: ["event Transfer(address indexed from, address indexed to, uint256 value)"],
argKeys: {
Copy link
Member

@vrtnd vrtnd Sep 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. need to add token
  2. add import to /adapters/index.ts

u can run tests using npm run test chain-fusion 1000

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do I need to add token for ETH as well, or should I use the WETH address?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the test, I am getting:

> test
> tsx ./src/adapters/test.ts chain-fusion 1000

Is there any specific output I should be looking for?

@NikolasHai
Copy link
Author

Need to add destination chain if bridge contains only ethereum <-> icp or there are more than 2 chains?

We plan on also adding the ICP <-> BTC bridge in a second MR

iconLink: "icons:chain-fusion",
largeTxThreshold: 10000,
url: "https://dashboard.internetcomputer.org/",
chains: [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

u need to add at least 2 chains

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants