Add sturgeon and refactor code #10784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The adapter at projects/sturgeon exports TVL: |
Closed
a17
suggested changes
Jun 28, 2024
There was a problem hiding this comment.
While reviewing I found two problems:
- need to use
getTotalAmounts, i requested changes - arcUSD. as example, has price on coingecko (coingeckoId: 'arcana-2'), but not show price by this URL
https://coins.llama.fi/prices/current/real:0xb08f026f8a096e6d92eb5bcbe102c273a7a2d51c,real:0x4644066f535ead0cde82d209df78d94572fcbf14,real:0x90c6e93849e06ec7478ba24522329d14a5954df4,real:0x83fedbc0b85c6e29b589aa6bdefb1cc581935ecd,real:0xaec9e50e3397f9ddc635c6c429c8c7eca418a143,real:0x25ea98ac87a38142561ea70143fd44c4772a16b6,real:0x75d0cbf342060b14c2fc756fd6e717dfeb5b1b70,real:0xce1581d7b4ba40176f0e219b2cac30088ad50c7a,real:0x835d3e1c0aa079c6164aad21dcb23e60eb71af48
projects/sturgeon/index.js
Outdated
| const tridents = await api.multiCall({ abi: 'address:asset', calls: harvesterVaults }) | ||
| const tridentBalances = await api.multiCall({ abi: 'uint256:totalAssets', calls: harvesterVaults }) | ||
| const token0s = await api.multiCall({ abi: 'address:token0', calls: tridents }) | ||
| const token0Bals = await api.multiCall({ abi: 'uint256:getBalance0', calls: tridents }) |
There was a problem hiding this comment.
The getBalance0/1 methods return only the balance of the ALM contract minus protocol commissions, but to calculate TVL we need the sum of ALM's balance in the POOL and ALM contract balance. There is a method for this in Trident LiquidBox ALM:
/**
* @notice Calculates the vault's total holdings of token0 and token1 - in
* other words, how much of each token the vault would hold if it withdrew
* all its liquidity from Uniswap.
*/
function getTotalAmounts() external view returns (uint total0, uint total1, uint128 liquidity);This method need to be used instead getBalance0/1.
|
@g1nt0ki As I understand it, the test script uses a deployed API, which does not know about Coingeco ID for arcUSD and others tokens. |
|
The adapter at projects/sturgeon exports TVL: |
|
@a17 thanks for the review, fixed based on your comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.