Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce pysen #186

Closed
wants to merge 21 commits into from
Closed

Introduce pysen #186

wants to merge 21 commits into from

Conversation

kenoss
Copy link
Contributor

@kenoss kenoss commented Apr 17, 2021

Waits merging of #182 .

Introduce pysen.

kenoss
kenoss commented Apr 17, 2021
View reviewed changes
pyproject.toml
enable_black = true
enable_flake8 = true
enable_isort = true
enable_mypy = false
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turn on if you use mypy.

@YuriCat
Copy link
Contributor

YuriCat commented Apr 21, 2021 •
edited
Loading

Thank you for your great suggestion, @kenoss !
We think that pysen will surely help us maintaining good code but it's not the best timing for using it, right now.
We continue to pay attention to this library, and we will consider this again when HandyRL become a bigger project.

@kenoss
Copy link
Contributor Author

kenoss commented Apr 22, 2021

I see. Use this diffs freely when you need it.

@kenoss kenoss closed this Apr 22, 2021
@kenoss kenoss deleted the introduce-pysen branch April 22, 2021 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenoss @YuriCat