Move source installation in splitted files #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smutel
changed the title
|
Any review for this PR please ? |
smutel
force-pushed
the
AddPackageInstall
branch
2 times, most recently
from
cd4ce6e
to
53bc82a
Compare
cognifloyd
reviewed
Jul 19, 2021
| package: | ||
| name: "{{ redis_packages }}" | ||
| state: present | ||
| notify: "disable redis" |
There was a problem hiding this comment.
When we install redis on debian, it's enabled by default. There are two systemd config, one called redis-server.service and another called redis.service. I tried to override them with the role but it's not easy. I decided to disable them after installation to be able to install systemd config through the role.
There was a problem hiding this comment.
It's not a perfect solution but I did'nt find any other ... Feel free to suggest me other one.
smutel
force-pushed
the
AddPackageInstall
branch
from
53bc82a
to
f096ce2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #116
Fix #247