Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Add inline comments, remove info.xml #1155

Draft
wants to merge 19 commits into
base: v3
Choose a base branch
from
Draft

Conversation

DaveSkender
Copy link
Owner

@DaveSkender DaveSkender commented Jan 28, 2024

Description

The PR is primarily for code cleanup and to ensure wide consistent adoption of new conventions for inline XML commenting to replace the difficult to maintain info.xml files and to make better use of the new C#10 record class where appropriate to maximize their utility / compatibility with streaming applications.

Done when:

  • wait, to rebase from v3 after merge of feat: Full chain streaming prototypes #1092
  • add a top-level Interface or virtual where needed to ensure mockable.
  • all info.xml files are replaced with inline XML comments using the /// convention, making good use of cref and <inheritdoc/> from the IStockIndicators interface descriptions.
  • all public classes have /// comments (e.g. utility, streaming classes)
  • ensure all public data classes are converted to record type where possible
  • restore use of [Serializable] attribute, if needed

@DaveSkender DaveSkender added the on hold On hold / waiting label Jan 28, 2024
@DaveSkender DaveSkender added this to the v3 milestone Jan 28, 2024
@DaveSkender DaveSkender changed the base branch from main to v3 January 28, 2024 06:57

This comment was marked as outdated.

@DaveSkender DaveSkender changed the title chore: Add inline comments, record types refactor: Add inline comments, record types Mar 3, 2024
@DaveSkender DaveSkender self-assigned this Mar 31, 2024
@DaveSkender DaveSkender removed the on hold On hold / waiting label Oct 30, 2024
@DaveSkender DaveSkender changed the title refactor: Add inline comments, record types refactor: Add inline comments, remove info.xml Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

1 participant